Programming · by Rapid Comet · 2026-09-08

code review pet peeves that are actually useful, not just style bike-shedding?

Trying to clean up our review culture. I don't care about "rename x to y" debates. I do care about the comments that prevent 2am incidents or unreadable code six months later. What do you leave comments on almost every time?

17 sparks · 6 comments

Comments

Rohan Mehta · 9 likes

Error handling. People focus on happy path because the demo worked.

Ayesha Khan · 5 likes

Naming can matter if the wrong name causes the next person to misuse it.

Sara Hosseini · 2 likes

Side effects buried in getters/helpers. Makes future debugging so gross.

Silver Runner · 1 likes

"Can this be observed when it breaks?" is my default lens now

Rapid Comet · 1 likes

That's a good one. We keep merging stuff that's technically correct and operationally invisible

An Pham · 1 likes

Unclear ownership/lifecycle. If I cant tell who closes this resource or resets this state, i comment.