Programming · by Cedar Lantern · 2026-10-14

Code review etiquette: how nitpicky is too nitpicky in your team's culture?

Had a PR blocked over variable naming preference (not even wrong, just a style difference) while an actual logic bug sailed through in the same review. Not blaming the reviewer, just curious how other teams balance thoroughness with not bikeshedding on trivial stuff.

0 sparks · 7 comments

Comments

Narin Chai · 0 likes

linters and formatters should handle 90% of style nitpicks so humans can focus on logic, if your team doesnt have strict linting this will keep happening

Irene López · 0 likes

we have a rule: style comments must be prefixed with 'nit:' and are non-blocking, logic issues block the merge, works well for us

Jan Nowak · 0 likes

the 'nit:' prefix convention is genuinely one of the best lightweight process improvements ive seen adopted anywhere

Imogen Clarke · 0 likes

honestly sometimes reviewers nitpick style because they didnt actually understand the logic well enough to review it properly, thats the real problem to watch for

Urban Rider · 0 likes

ouch that hits close to home, ive definitely done the 'easy comment to seem engaged' thing without meaning to

Hugo Martin · 0 likes

ai code review tools have actually helped with this at my company, they catch the logic bugs humans miss while skipping the style debates entirely

Minji Kim · 0 likes

ultimately its a trust and psychological safety issue, people nitpick more when they dont trust the author's judgment generally